flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-20454][format][debezium] Allow to read metadata for debezium-avro-confluent format

Open limer2 opened this issue 3 years ago • 10 comments

What is the purpose of the change

The metadata fields below are currently unavailable when using debezium-avro-confluent fomat. Hence, enhance this format to allow read metadata fields by exposing them as read-only (VIRTUAL) table columns

  • ingestion-timestamp
  • source.timestamp
  • source.database
  • source.schema
  • source.table
  • source.properties

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

limer2 avatar Feb 14 '22 04:02 limer2

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit adefb85e1ad7c1597bc6b6b27d43ad334879732a (Mon Feb 14 04:44:57 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot avatar Feb 14 '22 04:02 flinkbot

CI report:

  • 485695c847fbd14357bbecd5776fa47ed29187e6 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Feb 14 '22 04:02 flinkbot

@limer2 looks like you linked an incorrect issue FLINK-24745

leonardBang avatar Feb 15 '22 10:02 leonardBang

@limer2 looks like you linked an incorrect issue FLINK-24745

@leonardBang sorry for my mistake. I've corrected the PR title now.

limer2 avatar Feb 16 '22 01:02 limer2

What's the status for this PR?

esselius avatar Aug 16 '22 13:08 esselius

Could anyone review this PR? It seems to be a very useful feature.

diarworld avatar Aug 23 '22 20:08 diarworld

@leonardBang Could you have a look at this PR or do you know who would be best to ask?

MartijnVisser avatar Sep 29 '22 10:09 MartijnVisser

@limer2 Could you rebase your PR?

MartijnVisser avatar Sep 29 '22 10:09 MartijnVisser

This would be super helpful to have merged. Are there any plans on pushing this forward?

creativedutchmen avatar Jan 02 '24 16:01 creativedutchmen

If the PR gets rebased and the CI passes, someone could take a look most likely.

MartijnVisser avatar Jan 03 '24 16:01 MartijnVisser