flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-24718][avro] update AVRO dependency to latest version

Open RyanSkraba opened this issue 4 years ago • 14 comments

What is the purpose of the change

  • Update AVRO dependency to the latest version

(Continuing on the work of https://github.com/apache/flink/pull/17623)

Brief change log

  • Updated org.apache.avro:avro:1.10.0 to org.apache.avro:avro:1.11.0

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is already covered by existing tests, such as flink-avro/.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: yes
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

RyanSkraba avatar Dec 16 '21 12:12 RyanSkraba

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit aa10e52fd13361ae77844d467e0a68bf200bd561 (Thu Dec 16 12:46:26 UTC 2021)

Warnings:

  • 2 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot avatar Dec 16 '21 12:12 flinkbot

CI report:

  • df4f1ac54636e14a49eff5004b71d1ab4491507d UNKNOWN
  • 4abd92362c11938f44f0ebfa85feafea9f66ff75 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Dec 16 '21 12:12 flinkbot

@flinkbot run azure

RyanSkraba avatar Dec 29 '21 08:12 RyanSkraba

@zentol I've discussed this briefly with @fapaul but we would like to get your opinion on it.

MartijnVisser avatar Jan 03 '22 15:01 MartijnVisser

I'm not really fond of the workaround. Does the avro-maven-plugin actually have to be in sync with the avro version?

zentol avatar Jan 11 '22 09:01 zentol

@RyanSkraba Can you elaborate on that?

MartijnVisser avatar Jan 11 '22 10:01 MartijnVisser

Hello: it's definitely best practice that the avro-maven-plugin is the same as the avro version. I would recommend waiting for 1.11.1, rather than having avro.version out of sync for the maven plugin!

On the positive side, the workaround is pretty inoffensive -- explicitly specifying a transitive dependency that is only used during the build.

Avro releases about twice a year, but we can ask for a release sooner rather than later as well. I haven't seen other reports from projects that use older versions of Maven.

RyanSkraba avatar Jan 11 '22 14:01 RyanSkraba

@RyanSkraba Since AVRO 1.11.1 is now released, could you update this PR?

MartijnVisser avatar Aug 03 '22 13:08 MartijnVisser

I'd love to see this in 1.16! I'm currently with limited connection, but I'll get this updated to 1.11.1 within the week.

RyanSkraba avatar Aug 03 '22 18:08 RyanSkraba

@flinkbot run azure

RyanSkraba avatar Aug 04 '22 16:08 RyanSkraba

Hello Team,

Can you please confirm, when we are planning to release Flink 1.16 with Avro 1.11.1?

eshadei avatar Aug 05 '22 06:08 eshadei

Hello! I've rebased, removed the maven workaround that we needed for 1.11.0 and squashed everything together. There is a CI failure with TPC-DS e2e tests, but I can't seem to determine if it's related!

RyanSkraba avatar Aug 08 '22 12:08 RyanSkraba

See FLINK-28789 for the cause of the e2e failure.

zentol avatar Aug 08 '22 14:08 zentol

Hello! For info, did this make it to the list for 1.16?

RyanSkraba avatar Aug 11 '22 07:08 RyanSkraba

@flinkbot run azure

MartijnVisser avatar Aug 30 '22 13:08 MartijnVisser

Hello! For info, did this make it to the list for 1.16?

Not yet, but perhaps we can still squeeze it in :)

MartijnVisser avatar Aug 30 '22 13:08 MartijnVisser