flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-24614][Connectors/PARQUET] Add Complex types support for parquet reader

Open meetjunsu opened this issue 4 years ago • 9 comments

What is the purpose of the change

Add array,map,row types support for parquet vectorized reader

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (docs)

meetjunsu avatar Nov 03 '21 07:11 meetjunsu

CI report:

  • af9dab2d8c244defc2a9b2aa2f18f1fad315ea7c Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Nov 03 '21 07:11 flinkbot

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8a4c81675b4dd943f0c8a86f6cd9515016ecddb5 (Wed Nov 03 07:41:27 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot avatar Nov 03 '21 07:11 flinkbot

@JingsongLi could you help to review this PR ？

meetjunsu avatar Nov 03 '21 07:11 meetjunsu

@meetjunsu Thanks for the PR! Would this also make it possible to support this for DataStream API users?

MartijnVisser avatar Nov 03 '21 11:11 MartijnVisser

@meetjunsu Thanks for the PR! Would this also make it possible to support this for DataStream API users?

As far as I know ParquetColumnarRowInputFormat is a subclass of BulkFormat, users can use it through FileSource.forBulkFileFormat.

meetjunsu avatar Nov 04 '21 03:11 meetjunsu

@meetjunsu Can you help update this pr by rebase the master branch?

lsyldliu avatar Jun 11 '22 10:06 lsyldliu

ping @meetjunsu

lsyldliu avatar Jun 15 '22 07:06 lsyldliu

Due to @meetjunsu had not respond for a long time, I will take over it. Thanks for @meetjunsu contribution.

lsyldliu avatar Jun 19 '22 03:06 lsyldliu

Continuing this work in https://github.com/apache/flink/pull/20442, this pr will be closed.

lsyldliu avatar Aug 03 '22 17:08 lsyldliu