flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-9465][Runtime/Checkpointing] Specify a separate savepoint timeout option via CLI and REST API

Open zoltar9264 opened this issue 3 years ago • 4 comments

What is the purpose of the change

This pull request support specify a separate savepoint timeout option via REST API and CLI, which is decribed in FLINK-9465.

Brief change log

  • CheckpointCoordinator.CheckpointTriggerRequest add savepointTimeout field,
  • CheckpointCoordinator#createPendingCheckpoint() add a "timeout" parameter, and use it as canceller trigger delay if it > 0,
  • CheckpointCoordinator, RestfulGateway, JobMasterGateway,SchedulerNG,ClusterClient add triggerSavepoint/stopWithSavepoint method with parameter "savepointTimeout"
  • CliFrontend#savepoint(), CliFrontend#stop(), SavepointTriggerHandler, StopWithSavepointHandler migrate to method with "savepointTimeout"

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

zoltar9264 avatar Oct 09 '21 09:10 zoltar9264

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 79df4a732b55a8e7a0179b337776e36f7df5c83e (Sat Oct 09 09:23:35 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot avatar Oct 09 '21 09:10 flinkbot

CI report:

  • 06a5f4448434e12912dbd35ac60332ea510e16ff Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Oct 09 '21 09:10 flinkbot

@flinkbot run azure

zoltar9264 avatar Oct 15 '21 12:10 zoltar9264

@flinkbot run azure

zoltar9264 avatar Oct 16 '21 11:10 zoltar9264

Hi, @zoltar9264 Just Kindly ping, Are you still working on the pr? Could you rebase the newest master branch and resolve comments?

masteryhx avatar Aug 23 '23 02:08 masteryhx

Thanks for the reminder @masteryhx , this work was indeed interrupted for a long time. I would love to pick up this job next week. Thanks !

zoltar9264 avatar Aug 23 '23 06:08 zoltar9264