flink-kubernetes-operator icon indicating copy to clipboard operation
flink-kubernetes-operator copied to clipboard

[FLINK-29695] Create a utility to report the status of the last savep…

Open clarax opened this issue 2 years ago • 3 comments

…oint

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-29695 Users want to know the status of last savepoint, especially for manually triggered ones, to manage savepoints. Currently, users can infer the status of the last savepoint (PENDING, SUCCEEDED and ABANDONED) from jobStatus.triggerId, lastSavepoint.triggerNonce, spec.job.savepointTriggerNonce and savepointTriggerNonce from last reconciliation. If the last savepoint is not manually triggered, there is no ABANDONED status, only PENDING or SUCCEEDED. Creating a utility will encapsulate the internal logic of Flink operator guard against regression by any future version changes.

Brief change log

  • Added SavepointStatus class and getLastSavepointStatus method to SavepointUtils

Verifying this change

Added verification of savepoint status in existing SavepointOserverTests and ApplicationReconcilerTests for manual and non-manual savepoints for all types of SavepointStatus

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): No
  • The public API, i.e., is any changes to the CustomResourceDescriptors: No
  • Core observer or reconciler logic that is regularly executed: No

Documentation

  • Does this pull request introduce a new feature? No
  • If yes, how is the feature documented? No

clarax avatar Oct 19 '22 18:10 clarax

Hi @tweise can you please kick the build workflow off on this?

morhidi avatar Oct 19 '22 19:10 morhidi

or @gyfora @mbalassi when you are online

morhidi avatar Oct 19 '22 19:10 morhidi

Triggered CI based on @morhidi's request. @clarax once you will have a PR merged this will proceed automatically.

mbalassi avatar Oct 19 '22 20:10 mbalassi

Generated the doc updates and pushed.

Triggered CI based on @morhidi's request. @clarax once you will have a PR merged this will proceed automatically.

Got it. Thank you.

clarax avatar Oct 20 '22 00:10 clarax

@mbalassi @gyfora pls retrigger

morhidi avatar Oct 20 '22 00:10 morhidi

"mvn clean verify" and local rerun of the failed test "testRollbackSession" passed. The errors in the log seems transient errors.

clarax avatar Oct 20 '22 18:10 clarax

Local docker build and deployment to Minikube succeeded while image build and deployment failed on the workflow. Anything else I should look?

clarax avatar Oct 20 '22 23:10 clarax