flink-connector-kafka icon indicating copy to clipboard operation
flink-connector-kafka copied to clipboard

[FLINK-25538][Connectors/Kafka] Migration flink-connector-kafka from junit4 to junit5

Open victor09091 opened this issue 1 year ago • 4 comments

What is the purpose of the change

  • [JUnit5 Migration] Module: flink-connector-kafka. *

Brief change log

  • Updated simple junit 4 test packages to junit 5 test packages

Verifying this change

  • This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? no)
  • If yes, how is the feature documented? (not applicable)

victor09091 avatar Nov 09 '23 01:11 victor09091

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

boring-cyborg[bot] avatar Nov 09 '23 01:11 boring-cyborg[bot]

@victor09091 Can you please rebase your PR?

MartijnVisser avatar Jan 18 '24 15:01 MartijnVisser

Hello @victor09091, @MartijnVisser,

Any update on this issue? Otherwise I'd happy to continue the work and finish the migration. Please let me know 👍

morazow avatar May 24 '24 19:05 morazow

@morazow Feel free to take it over :)

MartijnVisser avatar Jun 03 '24 07:06 MartijnVisser