flink-connector-kafka icon indicating copy to clipboard operation
flink-connector-kafka copied to clipboard

[hotfix][docs] Fix scan.bounded.mode missing forward options

Open Tan-JiaLiang opened this issue 1 year ago • 1 comments

  1. add scan.bounded.mode, scan.startup.specific-offsets, scan.bounded.specific-offsets to the forward options.
  2. remove sink.parallelism from the forward options.
  3. fix the scan.bounded.mode docs.
  4. improve Chinese docs.

Tan-JiaLiang avatar Oct 13 '23 02:10 Tan-JiaLiang

@MartijnVisser Sorry late.

Do we have tests for them?

To be honest, I checked all connectors(e.g. jdbc/hbase/filesystem...) but there is no test case for forward options.

Forward options is a set of ConfigOption that are directly forwarded to the runtime implementation but don't affect the final execution topology. And according to the design of FLINK-24456, scan.bounded.mode, scan.bounded.specific-offsets, scan.bounded.timestamp-millis should be forward options.

And can you also check the Chinese docs?

Yes, I filled in the gaps in the Chinese documentation and translated the content.

Finally, the sink.parallelism option should not be a forward option, as it can lead to inconsistent parallelism between upstream and downstream operators and change the execution topology.

Tan-JiaLiang avatar Jan 26 '24 07:01 Tan-JiaLiang