flink-connector-kafka icon indicating copy to clipboard operation
flink-connector-kafka copied to clipboard

[FLINK-32893][Connectors/Kafka] Allow the clientid to be fully configurable

Open bdbene opened this issue 1 year ago • 5 comments

What is the purpose of the change

FLINK-32893 There's some use cases to use the same clientID across all of the low level Kafka consumers to

  1. Simplify how quotas are applied
  2. Lower the cardinality of metrics reported by the Kafka brokers

Brief Change Log

Support an optional configuration for the exact clientID to run Kafka consumers with

Verifying this change

It's difficult to write unit tests for this which is probably why there's no existing unit tests for the client ID. However I was able to run this locally and could see the client ID was logged exactly as I specified it (no prefix or suffix).

bdbene avatar Aug 23 '23 21:08 bdbene

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

boring-cyborg[bot] avatar Aug 23 '23 21:08 boring-cyborg[bot]

@bdbene Can you please rebase your PR?

MartijnVisser avatar Jan 18 '24 15:01 MartijnVisser

Done :)

bdbene avatar Jan 18 '24 21:01 bdbene

@bdbene Please rebase instead of merging, since we can't merge in merge commits

MartijnVisser avatar Jan 18 '24 21:01 MartijnVisser

Oops, fixed that

bdbene avatar Jan 18 '24 21:01 bdbene