flink-connector-kafka icon indicating copy to clipboard operation
flink-connector-kafka copied to clipboard

[FLINK-36906] Optimize the logic for determining if a split is finished

Open xiaochen-zhou opened this issue 1 year ago • 3 comments

When determining if a split is finished, process only the partitions with data from the current fetch instead of all partitions. This reduces unnecessary partition checks and improves performance and resource utilization.

xiaochen-zhou avatar Dec 16 '24 05:12 xiaochen-zhou

Friendly ping, do you have time to take a look @AHeise 🙏 ?

xiaochen-zhou avatar Dec 16 '24 05:12 xiaochen-zhou

Afaik this doesn't work and was the main reason for #100. If you last message is a transaction marker, then you would never check the stop condition on that partition at the point in time.

I'll trigger the CI which should fail for the test that was specifically added for that scenario.

I'll leave this PR open untli we figured out if it can indeed be improved. Please double check the linked PR and the respective ticket.

AHeise avatar Dec 16 '24 07:12 AHeise

Afaik this doesn't work and was the main reason for #100. If you last message is a transaction marker, then you would never check the stop condition on that partition at the point in time.

I'll trigger the CI which should fail for the test that was specifically added for that scenario.

I'll leave this PR open untli we figured out if it can indeed be improved. Please double check the linked PR and the respective ticket.

OK.

xiaochen-zhou avatar Dec 17 '24 10:12 xiaochen-zhou