flink-connector-jdbc icon indicating copy to clipboard operation
flink-connector-jdbc copied to clipboard

Published 20 hours ago • verified publisher icon apache

[FLINK-36303] PostgreSQL timestamp precision 0 not supported

Open kgeis opened this issue 1 year ago • 4 comments

fixes FLINK-36303

kgeis avatar Sep 17 '24 23:09 kgeis

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

boring-cyborg[bot] avatar Sep 17 '24 23:09 boring-cyborg[bot]

Hi @kgeis, sorry for the late review.. Could you fix the commit message?

@1996fanrui LGTM

eskabetxe avatar Jan 01 '25 12:01 eskabetxe

Thanks, @eskabetxe. I had renamed the PR and didn't know how to clear that check, and I appreciate the pointer. I've never renamed a pushed commit before. Always learning!

I look forward to this being implemented. It might enable moving a not-very-Big-Data search engine ingestion app from Spark to an apparently leaner Flink.

kgeis avatar Jan 03 '25 22:01 kgeis

@1996fanrui 🙏

kgeis avatar Apr 09 '25 23:04 kgeis

Any chance of this getting into 4.1? The underlying issue blocks me from using Flink.

kgeis avatar May 29 '25 19:05 kgeis

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Jun 05 '25 07:06 boring-cyborg[bot]

https://github.com/apache/flink-connector-jdbc/actions/runs/15461448916/job/43523504320#step:16:1014

hey @kgeis , it seems the CI fails due to this PR, would you mind checking it in your free time? thanks.

1996fanrui avatar Jun 05 '25 08:06 1996fanrui

I found the problem. The integration test is hard-coded to the old behavior. Can this PR be reopened, or should I start a new PR?

kgeis avatar Jun 05 '25 17:06 kgeis

Thanks for the quick response!

I found the problem. The integration test is hard-coded to the old behavior. Can this PR be reopened, or should I start a new PR?

A new PR is needed.

1996fanrui avatar Jun 05 '25 17:06 1996fanrui

Created #172 to fix the integration test.

kgeis avatar Jun 05 '25 18:06 kgeis