flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

[FLINK-36517][cdc-connect][paimon] use filterAndCommit API for Avoid commit the same datafile duplicate

Open beryllw opened this issue 1 year ago • 4 comments

https://issues.apache.org/jira/browse/FLINK-35938 problem still persists.

storeMultiCommitter.commit API may cause the same datafile commit twice when job restart from failure.

beryllw avatar Oct 12 '24 07:10 beryllw

@lvyanquan @leonardBang PTAL

beryllw avatar Oct 12 '24 07:10 beryllw

Could you please assist in reviewing this PR? Thank you. @lvyanquan

beryllw avatar Oct 15 '24 02:10 beryllw

I agree that the issue of duplicate commits still exists. Our testing in the case of abnormal failover is relatively lacking, can you try adding corresponding test case for this?

lvyanquan avatar Oct 15 '24 08:10 lvyanquan

I agree that the issue of duplicate commits still exists. Our testing in the case of abnormal failover is relatively lacking, can you try adding corresponding test case for this?

I will try, thanks.

beryllw avatar Oct 15 '24 10:10 beryllw

The test fails because the checkpointId is always 1. I'll fix it. https://github.com/apache/flink-cdc/pull/3652/files

beryllw avatar Nov 05 '24 04:11 beryllw

@beryllw Would you like to backport this fix to release-3.2 branch?

leonardBang avatar Nov 11 '24 11:11 leonardBang

OK.

beryllw avatar Nov 11 '24 12:11 beryllw