flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

[docs][minor] Correct Typos in Documentation/Code

Open Karl-WangSK opened this issue 1 year ago • 10 comments

This change ensures that the log message is clear and free of typographical errors.

Karl-WangSK avatar Jul 04 '24 07:07 Karl-WangSK

@yuxiqian PTAL

Karl-WangSK avatar Jul 04 '24 07:07 Karl-WangSK

Thanks for @Karl-WangSK's contribution! It reminds me that JetBrains IDE always complains about typos in code comments. Would you like to fix them together if possible?

yuxiqian avatar Jul 04 '24 08:07 yuxiqian

Looks good! Since some changes affected test cases, could @ruanhang1993 please trigger the CI?

yuxiqian avatar Jul 04 '24 12:07 yuxiqian

hello , pls can trigger the CI e2e check? this cancelled not related to this pr. @ruanhang1993 @leonardBang

Karl-WangSK avatar Jul 08 '24 07:07 Karl-WangSK

Seems OracleE2eITCase.testOracleCDC missed a change inside:

arrays first differed at element [7];
expected:<...,jacket,water resist[a]nt black wind breake...>
 but was:<...,jacket,water resist[e]nt black wind breake...>

yuxiqian avatar Jul 09 '24 03:07 yuxiqian

ready to merge @leonardBang

Karl-WangSK avatar Aug 14 '24 02:08 Karl-WangSK

Hi @Karl-WangSK, any updates on this PR?

yuxiqian avatar Sep 05 '24 06:09 yuxiqian

Hi @Karl-WangSK, any updates on this PR?

sry for late, revised

Karl-WangSK avatar Sep 05 '24 11:09 Karl-WangSK

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

github-actions[bot] avatar Nov 05 '24 00:11 github-actions[bot]

@Karl-WangSK Would you like to rebase this PR? and then we can review this PR again.

leonardBang avatar Nov 05 '24 03:11 leonardBang