flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

[FLINK-35344][cdc-base] Move same code from multiple subclasses to JdbcSourceChunkSplitter

Open loserwang1024 opened this issue 1 year ago • 3 comments

Current, subclasses of JdbcSourceChunkSplitter almost share same code, but each have one copy. It's hard for later maintenance.

Thus, this Jira aim to move same code from multiple subclasses to JdbcSourceChunkSplitter, just like what have done in AbstractScanFetchTask(https://github.com/apache/flink-cdc/issues/2690)

loserwang1024 avatar May 14 '24 04:05 loserwang1024

@PatrickRen , @ruanhang1993 , @leonardBang , CC

loserwang1024 avatar May 15 '24 02:05 loserwang1024

~~Seems MySQL CI took significantly time (90min vs. 30min) and failed eventually. Could loserwang1024 please take a look?~~

~~Failed CI job link: https://github.com/apache/flink-cdc/actions/runs/9073569533/job/24931065832~~

yuxiqian avatar May 15 '24 04:05 yuxiqian

Could @loserwang1024 please take a look?

I'd like to do it. But this PR do nothing with mysql & mongo cdc.

loserwang1024 avatar May 15 '24 05:05 loserwang1024

Just rebase this pr to master.

loserwang1024 avatar Aug 02 '24 08:08 loserwang1024