flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

add ignore no primary key table param

Open dufeng1010 opened this issue 1 year ago • 5 comments

add ignore.noprimarykey.table param, default this param is false, but when this param is set to true, it can ignore no primary key tables. fix #3006

dufeng1010 avatar Jan 26 '24 09:01 dufeng1010

Can you add a test like testCreateSource?

lvyanquan avatar Jan 26 '24 09:01 lvyanquan

@dufeng1010 I think we should log print ignored table name. Beacause it can help user to check config. And add doc for param ignore.noprimarykey.table

gong avatar Jan 29 '24 04:01 gong

@dufeng1010 I think we should log print ignored table name. Beacause it can help user to check config. And add doc for param ignore.noprimarykey.table

@dufeng1010 +1 for this. I think it is better to print the filtered tables in the log.

ruanhang1993 avatar Feb 04 '24 06:02 ruanhang1993

@dufeng1010 I think we should log print ignored table name. Beacause it can help user to check config. And add doc for param ignore.noprimarykey.table

@dufeng1010 +1 for this. I think it is better to print the filtered tables in the log.

282d9ad583304f458fc34139b5582a30

there are already print all available tables, but it`s better to print the filtered tables in the log

everhopingandwaiting avatar Feb 04 '24 06:02 everhopingandwaiting

i will fix it.

dufeng1010 avatar Feb 05 '24 08:02 dufeng1010

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

github-actions[bot] avatar Jul 17 '24 00:07 github-actions[bot]