flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard
verified publisher icon apache

Update OracleSourceBuilder's constructor to private

Open zhaomin1423 opened this issue 2 years ago • 4 comments

zhaomin1423 avatar Jul 20 '23 06:07 zhaomin1423

@zhaomin1423 Please update SqlServerSourceBuilder too.

GOODBOY008 avatar Jul 25 '23 06:07 GOODBOY008

Updated, thanks.

---- Replied Message ---- | From | @.> | | Date | 07/25/2023 14:09 | | To | @.> | | Cc | @.> , @.> | | Subject | Re: [ververica/flink-cdc-connectors] Update OracleSourceBuilder's constructor to private (PR #2327) |

@zhaomin1423 Please update SqlServerSourceBuilder too.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

zhaomin1423 avatar Jul 25 '23 06:07 zhaomin1423

Could you help me review it? @GOODBOY008 @leonardBang @ruanhang1993

zhaomin1423 avatar Jul 26 '23 13:07 zhaomin1423

Thanks @zhaomin1423 for the great work! Before this PR could be merged, could you please rebase it with latest master branch?

yuxiqian avatar Apr 26 '24 03:04 yuxiqian

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

github-actions[bot] avatar Jul 17 '24 00:07 github-actions[bot]