flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

[oracle-cdc] Fix read one record in the incremental snapshot

Open e-mhui opened this issue 2 years ago • 3 comments

Fix bug: #1886

In the snapshot, record.key() is null, so it will overwrite the previous record. So we can to add record without primary key into list.

  if (!reachChangeLogStart) {
      if (record.key() == null) {
          snapshotRecordsWithoutKey.add(record);
      } else {
          outputBuffer.put((Struct) record.key(), record);
      }
  }

e-mhui avatar Feb 14 '23 08:02 e-mhui

Maybe this is a new feature that make oracle cdc support the tables without primary keys.

ruanhang1993 avatar Jul 05 '23 09:07 ruanhang1993

Thanks @e-mhui for the great work! Before this PR could be merged, could you please rebase it with latest master branch?

cc @ruanhang1993

yuxiqian avatar Apr 26 '24 02:04 yuxiqian

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

github-actions[bot] avatar Jul 17 '24 00:07 github-actions[bot]