flink-cdc
flink-cdc copied to clipboard
[oceanbase] Add new deserialization schema with runtime converter
The previous logic is to do the first conversion with OceanBaseJdbcConverter helper methods, and then use runtime converters in JdbcValueConverters to do the second conversion. Now we need only do conversion one time with the new deserialization schema.
close #980 close #1289
@leonardBang please help to review this pr. The test failure seems not related to my modification, so I will not try to fix it.
Any maintainer can help review this? @GOODBOY008 @Jiabao-Sun
@ruanhang1993 Would you like to help review this PR ?
There might be something wrong on the self-hosted agent machine, the oceanbase container can't be started now. @leonardBang
There might be something wrong on the self-hosted agent machine, the oceanbase container can't be started now. @leonardBang
let me see see
Thanks for your work. I have left some comments. Besides these, I find that there are many duplicated code between the new code and the code in module
flink-connector-debezium
, e.g.AppendMetadataCollector
. Is there a way to reuse them?
It's hard to reuse codes in RowDataDebeziumDeserializeSchema
and AppendMetadataCollector
in debezium module, because they both are final classes.
@ruanhang1993 Any question for now?
@ruanhang1993 Any question for now?
No more questions from my side. : )
Any progress for this PR? @leonardBang