flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

[oceanbase] Add new deserialization schema with runtime converter

Open whhe opened this issue 2 years ago • 9 comments

The previous logic is to do the first conversion with OceanBaseJdbcConverter helper methods, and then use runtime converters in JdbcValueConverters to do the second conversion. Now we need only do conversion one time with the new deserialization schema.

close #980 close #1289

whhe avatar Jul 07 '22 08:07 whhe

@leonardBang please help to review this pr. The test failure seems not related to my modification, so I will not try to fix it.

whhe avatar Jul 07 '22 14:07 whhe

Any maintainer can help review this? @GOODBOY008 @Jiabao-Sun

whhe avatar Jul 21 '22 13:07 whhe

@ruanhang1993 Would you like to help review this PR ?

leonardBang avatar Aug 10 '22 06:08 leonardBang

There might be something wrong on the self-hosted agent machine, the oceanbase container can't be started now. @leonardBang

whhe avatar Aug 11 '22 03:08 whhe

There might be something wrong on the self-hosted agent machine, the oceanbase container can't be started now. @leonardBang

let me see see

leonardBang avatar Aug 11 '22 04:08 leonardBang

Thanks for your work. I have left some comments. Besides these, I find that there are many duplicated code between the new code and the code in module flink-connector-debezium, e.g. AppendMetadataCollector. Is there a way to reuse them?

It's hard to reuse codes in RowDataDebeziumDeserializeSchema and AppendMetadataCollector in debezium module, because they both are final classes.

whhe avatar Aug 11 '22 15:08 whhe

@ruanhang1993 Any question for now?

whhe avatar Aug 15 '22 08:08 whhe

@ruanhang1993 Any question for now?

No more questions from my side. : )

ruanhang1993 avatar Aug 16 '22 04:08 ruanhang1993

Any progress for this PR? @leonardBang

whhe avatar Aug 29 '22 06:08 whhe