flink-cdc icon indicating copy to clipboard operation
flink-cdc copied to clipboard

Published 20 hours ago • verified publisher icon apache

[mysql] keep order of each split by replacing HashMap with LinkedHashMap

Open yujiaxinlong opened this issue 2 years ago • 6 comments

#1074

When creating normalizedSplitRecords in RecordUtils, original order of records are lost because the use of HashMap. Since the order might be useful in some occasion, it's better to replace HashMap with LinkedHashMap to keep the order.

There is no big efficiency difference between HashMap and LinkedHashMap, so there seems no need to have a new property to config this.

yujiaxinlong avatar Apr 14 '22 03:04 yujiaxinlong

@leonardBang can you review this PR?

yujiaxinlong avatar Apr 21 '22 06:04 yujiaxinlong

https://github.com/ververica/flink-cdc-connectors/pull/1231 has changed this part of code. You need to rebase master branch.

ruanhang1993 avatar Jul 07 '22 03:07 ruanhang1993

#1231 has changed this part of code. You need to rebase master branch.

thanks， just resolved it.

can you help rerun the checks, the errors seems irrelevent

yujiaxinlong avatar Sep 19 '22 01:09 yujiaxinlong

Hi @yujiaxinlong, sorry for the delay of this PR. Could you please rebase it to latest master branch since there’s been lots of changes in Flink CDC repo since your original commit? Kindly reminder that com.ververica.cdc.connectors.mysql package has been moved to org.apache.flink.cdc.connectors.mysql.

Thanks for your contribution!

yuxiqian avatar Apr 25 '24 06:04 yuxiqian