FINERACT-2081: introduce builder pattern to Note entity instantiation.
Description
- Removed all redundant static instantiation methods and constructors from
Note.java. - Used Builder pattern to make it easy to instantiate the Note object.
- Changed all instantiation places to use the new implementation.
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
-
[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
-
[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
-
[ ] Create/update unit or integration tests for verifying the changes made.
-
[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
-
[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
-
[ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
@kjozsa
Are there any required updates?
@Zeyad2003 I'm fine, but I recall @vidakovic also had concerns with the nature of the changes. Let's get him review your work as well before we proceed here.
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.