apache
FINERACT-2081: Validation error in mandatory loan account parameters
Description
In CreateLoan request, missing mandatory fields which were being returned as 400 in the past are currently being returned as 403 ? Is this an expected change? Please confirm. The following fields are being returned with 403 code when missing
- clientId
- productId
- principal
- transactionProcessingStrategyCode
- expectedDisbursementDate
- submittedOnDate
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
-
[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
-
[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
-
[ ] Create/update unit or integration tests for verifying the changes made.
-
[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
-
[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
-
[ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
I just note that this is being done on an open ended ticket for "small bug fixes" (2081).... is this a new functionality or a bug fix and if a bug fix the idea should be to make sure the approach is clear, maintainable by the next person coming along. If the logic and approach is not clear then that defeats the purpose of the changes. The definition of "DONE" needs to be better than we found it.
