fineract icon indicating copy to clipboard operation
fineract copied to clipboard
verified publisher icon apache

FINERACT-1960: Accrual Transactions For Savings batch job - Interest

Open alberto-art3ch opened this issue 1 year ago • 7 comments

Description

Describe the changes made and why they were made.

Financial institutions will want to recognize expenses/incomes accrued on deposit product accounts too similar to the Loan products.

In this case we are adding the Accrual Transactions For Savings batch job

FINERACT-1960

Screenshot 2024-07-15 at 5 26 05 p m

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [ ] Create/update unit or integration tests for verifying the changes made.

  • [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

alberto-art3ch avatar Jul 15 '24 23:07 alberto-art3ch

@adamsaghy @marta-jankovics will you be able to help us in reviewing this PR please?

bharathcgowda avatar Jul 16 '24 06:07 bharathcgowda

@adamsaghy @marta-jankovics will you be able to help us in reviewing this PR please?

I have done my best, but it would be nice to read a couple sentences about what this PR is intended to implement.

adamsaghy avatar Jul 16 '24 11:07 adamsaghy

@adamsaghy @marta-jankovics will you be able to help us in reviewing this PR please?

I have done my best, but it would be nice to read a couple sentences about what this PR is intended to implement.

Done, almost all the comments were attended or commented

alberto-art3ch avatar Jul 16 '24 17:07 alberto-art3ch

@alberto-art3ch Kindly see my review!

adamsaghy avatar Jul 17 '24 11:07 adamsaghy

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Aug 17 '24 00:08 github-actions[bot]

@alberto-art3ch is this being worked on?

galovics avatar Sep 11 '24 09:09 galovics

@alberto-art3ch can you provide an update on this please?

galovics avatar Oct 04 '24 16:10 galovics

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Nov 04 '24 00:11 github-actions[bot]