fineract icon indicating copy to clipboard operation
fineract copied to clipboard

FINERACT-1926: Fix No Such Element exception in Asset buyback

Open alberto-art3ch opened this issue 1 year ago • 1 comments

Description

There is a NoSuchElementException when the Loan COB is executed in some specific scenario.

FINERACT-1926

Screenshot 2024-04-10 at 6 13 09 p m

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [ ] Create/update unit or integration tests for verifying the changes made.

  • [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

alberto-art3ch avatar Apr 11 '24 00:04 alberto-art3ch

@alberto-art3ch I dont see any testing! Please consider writing unit tests to cover this new behaviour! The test should check whether properly handled the CANCELLATION if there is no ACTIVE transfer and whether business event was sent about the CANCELLATION too!

adamsaghy avatar Apr 11 '24 08:04 adamsaghy