fineract icon indicating copy to clipboard operation
fineract copied to clipboard

FINERACT-2073: Client search v2 using Client Identifiers

Open alberto-art3ch opened this issue 1 year ago • 5 comments

Description

Client search v2 using Client Identifiers in the search values as we have in the general search endpoint. There is not impact or change needed in the UI

FINERACT-2073

Screenshot 2024-03-26 at 12 50 40 a m

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [ ] Create/update unit or integration tests for verifying the changes made.

  • [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

alberto-art3ch avatar Mar 26 '24 07:03 alberto-art3ch

Kindly add the proper FINERACT story for this PR and check my review!

Done

alberto-art3ch avatar Apr 04 '24 05:04 alberto-art3ch

Please update the Commit message too!

adamsaghy avatar Apr 04 '24 08:04 adamsaghy

Please update the Commit message too!

adamsaghy avatar Apr 09 '24 18:04 adamsaghy

Please update the Commit message too!

Done! Commit message updated

alberto-art3ch avatar Apr 09 '24 22:04 alberto-art3ch

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar May 12 '24 00:05 github-actions[bot]