fineract icon indicating copy to clipboard operation
fineract copied to clipboard

Use of Lombok Getter annotation in GroupLevelData

Open Malaydewangan09 opened this issue 1 year ago • 6 comments

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [ ] Create/update unit or integration tests for verifying the changes made.

  • [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Malaydewangan09 avatar Mar 09 '24 10:03 Malaydewangan09

Hi @Malaydewangan09

I think you missed some instructions from CONTRIBUTING.md. You need to mention the Jira ticket in your PR to be reviewed and track the changes.

Regards!

Zeyad2003 avatar Mar 10 '24 12:03 Zeyad2003

Hey @Zeyad2003 I checked through Jira tickets But this was not there, this was me just trying to start it out here.

Malaydewangan09 avatar Mar 10 '24 13:03 Malaydewangan09

You can create a sub-task under this improvement. e.g. "Introduce Lombok to group module" then refer to it in your PR.

Zeyad2003 avatar Mar 10 '24 13:03 Zeyad2003

Okay cool, thanks @Zeyad2003

Malaydewangan09 avatar Mar 10 '24 14:03 Malaydewangan09

@Zeyad2003 Please follow the conventions on how to format the pull request title ("FINERACT-1234: Title of the JIRA ticket")

vidakovic avatar Mar 10 '24 17:03 vidakovic

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Apr 10 '24 00:04 github-actions[bot]