fineract icon indicating copy to clipboard operation
fineract copied to clipboard

FINERACT-2023: Improve contributor's guide

Open abhinav7sinha opened this issue 1 year ago • 6 comments

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [x] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [x] Create/update unit or integration tests for verifying the changes made.

  • [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

abhinav7sinha avatar Feb 25 '24 11:02 abhinav7sinha

A few changes I think are needed.

agreed. I've made the changes now

abhinav7sinha avatar Mar 15 '24 17:03 abhinav7sinha

@abhinav7sinha Please fix the conflicts (rebase your PR) and squash the commits!

adamsaghy avatar Apr 03 '24 12:04 adamsaghy

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar May 04 '24 00:05 github-actions[bot]

Is this stale? What changes are needed to accept this?

jdailey avatar Jun 21 '24 15:06 jdailey