fineract icon indicating copy to clipboard operation
fineract copied to clipboard
verified publisher icon apache

FINERACT-1956: Added the skeleton structure necessary to publish doc …

Open jogathogo opened this issue 2 years ago • 13 comments

Description

Added the necessary folders and files for Antora to build the documentation site from asciidoc i.e Refer to https://docs.antora.org/antora/latest/

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [ ] Create/update unit or integration tests for verifying the changes made.

  • [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

jogathogo avatar Jul 25 '23 12:07 jogathogo

@vidakovic please review and advise.

jogathogo avatar Aug 02 '23 11:08 jogathogo

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Sep 02 '23 00:09 github-actions[bot]

Please reopen

jdailey avatar Oct 05 '23 12:10 jdailey

The suggested bits have been removed. Review and advise.

jogathogo avatar Oct 09 '23 10:10 jogathogo

LGTM

jdailey avatar Oct 23 '23 16:10 jdailey

Please don't merge this one before we've created release 1.9.0. Let's target 1.10.0. Jira tickets updated.

vidakovic avatar Nov 07 '23 07:11 vidakovic

Aleks - can we push now?

jdailey avatar Nov 30 '23 21:11 jdailey

No conflicts w base branch.

jdailey avatar Nov 30 '23 21:11 jdailey

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Dec 31 '23 00:12 github-actions[bot]

Please don't merge this one before we've created release 1.9.0. Let's target 1.10.0. Jira tickets updated.

@vidakovic now that 1.9 is out, can we resume this? This PR is purely documentation related and does not contain any fineract code and therefore should be safe to merge without breaking anything.

jogathogo avatar Jan 11 '24 08:01 jogathogo

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Mar 05 '24 00:03 github-actions[bot]

@jogathogo Please squash your commits and check why the tests were failing!

adamsaghy avatar Apr 03 '24 12:04 adamsaghy

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar May 05 '24 00:05 github-actions[bot]