fineract icon indicating copy to clipboard operation
fineract copied to clipboard

Published 20 hours ago • verified publisher icon apache

correct descriptions and summary on DELETE and PUT

Open wkigenyi opened this issue 2 years ago • 5 comments

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • [ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • [ ] Create/update unit or integration tests for verifying the changes made.

  • [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

wkigenyi avatar Jul 27 '22 20:07 wkigenyi

Please do a ./gradlew spotlessApply and then the tests will pass.

galovics avatar Jul 28 '22 09:07 galovics

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Aug 28 '22 00:08 github-actions[bot]

@wkigenyi ... could you please create a Jira ticket - a generic one... something like "Ongoing OpenAPI fixes" - for ongoing improvements of the OpenAPI manifest/annotations and format this PR title properly (e. g. "FINERACT-XXXX: Ongoing OpenAPI fixes - GL Account"; even if we ignore the reference to a Jira ticket (important for changelog when we do releases) then your current title does not give any indication where these changes are applied (we have a lot of DELETE and PUT annotated endpoints). Thanks.

vidakovic avatar Aug 28 '22 09:08 vidakovic

Will do in a about 3 hours. Thanks

wkigenyi avatar Aug 28 '22 15:08 wkigenyi

This isn't linked properly to a Jira ticket . please correct.

jdailey avatar Sep 01 '22 21:09 jdailey

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

github-actions[bot] avatar Oct 02 '22 00:10 github-actions[bot]