Felix Android Support

[phinney]

Three files changed: BundleWiringImpl, FelixConstansts and Felix

BundleRevisionImpl was unintentionally committed, and then re-committed back to its original state. I couldn't find a why to revoke the unintentional commit.

The attached file contains documentation explaining the implementation changes Apache Project.pdf

[karlpauls]

@phinney, judging by your documentation it sounds like you are going into the right direction - however, for some reason your PR doesn't seem right. Somehow, the files seems to have duplicated information in them or something. Could you please have another look and see if you can clean them up (either in this PR or by creating a new one)?

[phinney]

Karl,

I think I got it straighten out! As you might as well figured out, I’m not all that skillful using GitHub. I thought I could just edit the file an do a select all, and paste, but I see that’s not the case in GitHub. A search on the internet reveals I not the only one confused by that.

I been using the code with the changes and it has been pretty solid. As far as native code testing, I’ve verified that source code is copied out of the bundle and stored in the directory for the BundleRevison and that the proper directory paths has been added to the PathClassLoader. I’ve not actually invoked a native library method; that mechanism should however work as it has in the past. I will sometime in the future actually call a native library method and verify the full process. If you have an android bundle that contains native code for me to test that would be helpful.

-Tom Rutchik

From: Karl Pauls [mailto:[email protected]] Sent: Tuesday, September 18, 2018 12:47 PM To: apache/felix [email protected] Cc: Tom Rutchik [email protected]; Mention [email protected] Subject: Re: [apache/felix] Felix Android Support (#155)

@phinney https://github.com/phinney , judging by your documentation it sounds like you are going into the right direction - however, for some reason your PR doesn't seem right. Somehow, the files seems to have duplicated information in them or something. Could you please have another look and see if you can clean them up (either in this PR or by creating a new one)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache/felix/pull/155#issuecomment-422525793 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHYfdDpEY7oQlATxPIsYbM7pSYPLI9_Uks5ucU2ygaJpZM4WsQzU . https://github.com/notifications/beacon/AHYfdOjU0wuuLqq2jkNx0g5vEDbGfhnQks5ucU2ygaJpZM4WsQzU.gif