eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Enhancement] Consider implementing the Serializable interface

Open kirinzhu opened this issue 2 years ago • 2 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Enhancement Request

This class implements the Comparator interface. Maybe we consider whether or not it should also implement the Serializable interface. If a comparator is used to construct an ordered collection such as a TreeMap, then the TreeMap will be serializable only if the comparator is also serializable. Making them serializable is good defensive programming and could enhance the robustness of the program

Describe the solution you'd like

In module eventmesh-runtime In class org.apache.eventmesh.runtime.util.ValueComparator At [lines 23-29]

Consider implementing the Serializable interface

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

kirinzhu avatar Jul 07 '22 02:07 kirinzhu

I will finish this issue .

misselvexu avatar Jul 11 '22 08:07 misselvexu

[WeOpen Star] working on it

hezean avatar Aug 09 '22 16:08 hezean