eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Feature] Add file listener for ConfigurationWrapper class

Open mroccyen opened this issue 2 years ago • 2 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Feature Request

image

ConfigurationWrapper internally reads files at regular intervals, regardless of whether the files change or not, and the timer introduces a delay that causes configuration information to not be updated immediately after the change. I think the configuration information can be updated in real time by using WatchService to listen for changes in the configuration file.

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

mroccyen avatar May 25 '22 07:05 mroccyen

@mroccyen nice~

qqeasonchen avatar May 25 '22 08:05 qqeasonchen

good idea~

On Wed, May 25, 2022 at 3:06 PM mroccyen @.***> wrote:

Search before asking

Feature Request

[image: image] https://user-images.githubusercontent.com/22514893/170201176-3811aa8f-6b17-4645-893b-d14839275c45.png

ConfigurationWrapper internally reads files at regular intervals, regardless of whether the files change or not, and the timer introduces a delay that causes configuration information to not be updated immediately after the change. I think the configuration information can be updated in real time by using WatchService to listen for changes in the configuration file. Are you willing to submit PR?

  • Yes I am willing to submit a PR!

— Reply to this email directly, view it on GitHub https://github.com/apache/incubator-eventmesh/issues/890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGH3J5I6HFW2VT6MTJPJCATVLXGQ3ANCNFSM5W4B7EUQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

qqeasonchen avatar May 25 '22 08:05 qqeasonchen