eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Enhancement] Clean up some useless constants and classes

Open Alonexc opened this issue 3 years ago • 3 comments
trafficstars

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Enhancement Request

Clean up some useless constants and classes in the eventmesh-connector-plugin module.

Describe the solution you'd like

located in:eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/common The Constants and EventMeshContants classes in this package have a large number of unused Constants,we can remove them. image image

eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/domain/NonStandardKeys.java There are unused keys in this class image

ConsumeRequest and RocketMQConstants, under the same package, are not used. image image

eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/promise/FutureState.java This class is useless, so we can remove this package and this class. image

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Alonexc avatar Apr 25 '22 08:04 Alonexc

Hi,

I would like to work on this issue. Thanks!

Witness167 avatar Apr 26 '22 08:04 Witness167

@Witness167 Ok, welcome!

Alonexc avatar Apr 26 '22 09:04 Alonexc

@Witness167 How is the progress of this issue ?

xwm1992 avatar May 09 '22 11:05 xwm1992

@qqeasonchen , Looks like the fix for this issue is merged. Requesting to check and close the issue.

captainbkarthick avatar Oct 28 '22 12:10 captainbkarthick