[Enhancement] Extraction of constants [eventmesh-protocol-meshmessage]

[Alonexc]

trafficstars

Search before asking

• [X] I had searched in the issues and found no similar issues.

Enhancement Request

Describe the solution you'd like

Located at：eventmesh-protocol-meshmessage/src/main/java/org/apache/eventmesh/protocol/meshmessage/resolver Extract these constants from the image into the MeshMessageProtocolConstant.

Are you willing to submit PR?

• [ ] Yes I am willing to submit a PR!

[ruanwenjun]

@Alonexc Hi, thanks for your feedback, agree with you that we can use the constant to replace. According to our issue policy, we don't suggest creating an issue for these kinds of optimization, this will generate lots of minor issue, welcome to directly submit a PR if you think the code can be optimized. I will close this issue.

[xwm1992]

@Alonexc Hi, thanks for your feedback, agree with you that we can use the constant to replace. According to our issue policy, we don't suggest creating an issue for these kinds of optimization, this will generate lots of minor issue, welcome to directly submit a PR if you think the code can be optimized. I will close this issue.

I understand your idea, this issue is set up for the first time to participate in The EventMesh contributor, I will label it as good first issue and reopen it, thanks.

[ruanwenjun]

Got it, good idea.

[chakkk309]

Hi, I want to try it

[xwm1992]

Hi, I want to try it

welcome for your contribution~

[chakkk309]

Hi @xwm1992, It looks like RSTdefg has fixed the issue (link), I found out that he has made the corresponding commit.

[xwm1992]

Hi @xwm1992, It looks like RSTdefg has fixed the issue (link), I found out that he has made the corresponding commit.

Yes, this issue is quietly simple, so we just merged another pull request from RSTdefg, his pull request for this issue hasn't been merged.