eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #4136] change the null reference to empty object in UrlMappingPattern.java

Open heliang666s opened this issue 10 months ago • 4 comments

Motivation

change the null reference to empty object in UrlMappingPattern.java Fixes #4136

Modifications

change return null to a empty map

Documentation

No

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

heliang666s avatar Apr 17 '24 07:04 heliang666s

@heliang666s

The target branch you merge this PR into should be master instead of develop. By then you should be able to pass CI.

Developing with a branch that corresponds to a single issue minimizes the chance that you'll run into any Git difficulties.

By the way, kindly refer to the standard title format used in other PRs.

@mxsm How about delete this outdated develop branch?

Pil0tXia avatar Apr 17 '24 15:04 Pil0tXia

@heliang666s Please resolve conflicts.

@mxsm The The base branch was changed. comment was a automatic message sent by GitHub.

Pil0tXia avatar Apr 17 '24 15:04 Pil0tXia

Hi @heliang666s , the eventmesh-admin-rocketmq module referenced in this issue has been removed in https://github.com/apache/eventmesh/pull/4490 (merged on 2023-10-17). Do you have any additional information to share? Feel free to share your latest insights with us. If you feel that this issue has been resolved, you are welcome to close it. We sincerely appreciate your contributions to Apache EventMesh and you can pick another Good First Issue to start your first step.

Pil0tXia avatar Jun 10 '24 12:06 Pil0tXia

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Aug 11 '24 18:08 github-actions[bot]