eventmesh
eventmesh copied to clipboard
[Feature] Unify HTTP Source Connector and `eventmesh-webhook` module
Search before asking
- [X] I had searched in the issues and found no similar issues.
Feature Request
For the eventmesh-webhook module, it currently has these shortcomings:
- It only supports GitHub webhook protocol for now and it needs to support a more general protocol;
- Its implementation is too unique in EventMesh, which is hard to manage and extend
- It has some redundancy in functionality with the HTTP Source Connector and GitHub Source Connector, which needs to be revamped.
This issue brings about a change from thinking of the Runtime as an HTTP Webhook server to thinking of the Connector as an HTTP Webhook server for enhanced extensibility and manageability.
This issue can be resolved in the following steps:
- [x] Use the existing implementation of Webhook as an enhancement to the HTTP Source Connector, needs to be able to support the user's own implementation of a customized Webhook protocol: #4869
- [x] Supporting GitHub webhook protocol may supersed the webhook function of GitHub Source Connector, which means that there's no need to support Webhook in https://github.com/apache/eventmesh/issues/4416.
- [ ] Deprecate
eventmesh-webhookmodule and its special usages ineventmesh-runtime. (Link the PR resolving this task to this issue.)
Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct *
@Pil0tXia I want to do it! Can you please assign it to me?
@scwlkq You may start understanding eventmesh-webhook module from InsertWebHookConfigHandler class.