eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Unit Test] Update Unit tests for eventmesh-runtime admin endpoints

Open Pil0tXia opened this issue 1 year ago • 4 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Read the unit testing guidelines

  • [X] I have read.

Unit test request

As a result of the refactoring of https://github.com/apache/eventmesh/pull/4768, all of the unit test classes no longer work and need to be rewritten using Netty.

Describe the unit tests you want to do

Module name: eventmesh-runtime Located at: org.apache.eventmesh.runtime.admin.handler Task status: ×(unfinished)

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Pil0tXia avatar Apr 06 '24 07:04 Pil0tXia

Hi @Pil0tXia, i want to try this as my first issue

zhengkezhou1 avatar May 02 '24 13:05 zhengkezhou1

@zzzk1 Welcome to Apache EventMesh community!

Pil0tXia avatar May 02 '24 14:05 Pil0tXia

Hi, @Pil0tXia. In https://github.com/apache/eventmesh/pull/4768, there are three test cases that have been deleted, and I noticed 2 things.

  • eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/admin/handler/EventHandlerTest.java are using Netty directly.
  • This issue requires me to use Netty to support the deletion of those three test cases.

Am I understanding correctly?

zhengkezhou1 avatar May 03 '24 07:05 zhengkezhou1

@zzzk1 You can write unit tests on a case-by-case basis without specifically using Netty only for all of them.

Pil0tXia avatar May 03 '24 10:05 Pil0tXia