eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Feature #4793] Support MQTT protocol

Open karsonto opened this issue 1 year ago • 8 comments

Fixes #4793

Motivation

Explain the content here. Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

karsonto avatar Mar 19 '24 09:03 karsonto

Codecov Report

Attention: Patch coverage is 38.42207% with 960 lines in your changes missing coverage. Please review.

Project coverage is 16.11%. Comparing base (1600c6b) to head (44e61e9). Report is 4691 commits behind head on master.

Files with missing lines Patch % Lines
...mesh/connector/jdbc/connection/JdbcConnection.java 0.00% 137 Missing :warning:
...nnector/file/sink/connector/FileSinkConnector.java 0.00% 62 Missing :warning:
...r/jdbc/dialect/AbstractGeneralDatabaseDialect.java 0.00% 56 Missing :warning:
...g/apache/eventmesh/common/utils/JsonPathUtils.java 0.00% 54 Missing :warning:
...ava/org/apache/eventmesh/common/utils/LogUtil.java 7.54% 48 Missing and 1 partial :warning:
...tor/jdbc/connection/mysql/MysqlJdbcConnection.java 0.00% 43 Missing :warning:
...a/org/apache/eventmesh/connector/jdbc/Payload.java 0.00% 32 Missing :warning:
...dingtalk/sink/connector/DingDingSinkConnector.java 65.38% 24 Missing and 3 partials :warning:
...pache/eventmesh/connector/jdbc/CatalogChanges.java 0.00% 26 Missing :warning:
...ava/org/apache/eventmesh/connector/jdbc/Field.java 0.00% 24 Missing :warning:
... and 82 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4794      +/-   ##
============================================
- Coverage     16.93%   16.11%   -0.82%     
- Complexity     1413     1734     +321     
============================================
  Files           589      870     +281     
  Lines         25786    31682    +5896     
  Branches       2397     2739     +342     
============================================
+ Hits           4367     5106     +739     
- Misses        20983    26097    +5114     
- Partials        436      479      +43     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 19 '24 10:03 codecov[bot]

@karsonto I don’t understand the implementation of the publish processor, and I don’t see how messages of the mqtt protocol are converted and sent to eventmesh storage.


我没有理解对于publish processor的实现,没有看到将mqtt协议的消息进行转换后发送到eventmesh storage。

xwm1992 avatar Mar 26 '24 02:03 xwm1992

@xwm1992 This PR is the framework design of the MQTT protocol , and will continue to optimize persist messages in another PR.

karsonto avatar Mar 26 '24 02:03 karsonto

This PR is the framework design of the MQTT protocol , and will continue to optimize persist messages in another PR.

karsonto avatar Mar 26 '24 07:03 karsonto

Is eventmesh-protocol-plugin implementation the only work left for this protocol in Runtime?

I think there is unnecessry to implement this module for this time. If it needs to be implemented in the future, I will submit a PR to supplement it.

karsonto avatar Apr 15 '24 01:04 karsonto

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Aug 11 '24 18:08 github-actions[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Apr 14 '25 18:04 github-actions[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Jun 14 '25 18:06 github-actions[bot]