eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #4763] Do some code optimization.[EventMeshCommon]

Open scwlkq opened this issue 1 year ago • 7 comments

Fixes #4763

Motivation

move EventMeshCommon class to Common module.

Modifications

Documentation

  • Does this pull request introduce a new feature? (no)

scwlkq avatar Feb 01 '24 17:02 scwlkq

Codecov Report

Attention: Patch coverage is 39.76064% with 906 lines in your changes missing coverage. Please review.

Project coverage is 16.37%. Comparing base (1600c6b) to head (d751223). Report is 4691 commits behind head on master.

Files with missing lines Patch % Lines
...mesh/connector/jdbc/connection/JdbcConnection.java 0.00% 137 Missing :warning:
...nnector/file/sink/connector/FileSinkConnector.java 0.00% 62 Missing :warning:
...g/apache/eventmesh/common/utils/JsonPathUtils.java 0.00% 54 Missing :warning:
...ava/org/apache/eventmesh/common/utils/LogUtil.java 7.54% 48 Missing and 1 partial :warning:
...tor/jdbc/connection/mysql/MysqlJdbcConnection.java 0.00% 43 Missing :warning:
...dingtalk/sink/connector/DingDingSinkConnector.java 65.38% 24 Missing and 3 partials :warning:
...pache/eventmesh/connector/jdbc/CatalogChanges.java 0.00% 26 Missing :warning:
...ava/org/apache/eventmesh/connector/jdbc/Field.java 0.00% 24 Missing :warning:
...ava/org/apache/eventmesh/common/ThreadWrapper.java 59.64% 16 Missing and 7 partials :warning:
...tor/http/source/connector/HttpSourceConnector.java 67.74% 14 Missing and 6 partials :warning:
... and 92 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4764      +/-   ##
============================================
- Coverage     16.93%   16.37%   -0.56%     
- Complexity     1413     1734     +321     
============================================
  Files           589      856     +267     
  Lines         25786    31266    +5480     
  Branches       2397     2700     +303     
============================================
+ Hits           4367     5121     +754     
- Misses        20983    25665    +4682     
- Partials        436      480      +44     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Feb 02 '24 13:02 codecov[bot]

Is there any obstacles in this PR?

Pil0tXia avatar Feb 20 '24 17:02 Pil0tXia

Is there any obstacles in this PR?

Closed because I thought the issue was meaningless hahaha.

scwlkq avatar Feb 21 '24 11:02 scwlkq

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Jun 10 '24 18:06 github-actions[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Aug 11 '24 18:08 github-actions[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Apr 14 '25 18:04 github-actions[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Jun 14 '25 18:06 github-actions[bot]