Methods that continuously call WeakReference wrapper may throw an NPE

[liutaohua]

All methods using WeakReference must check whether it is NULL after calling get().

[ruanwenjun]

Yes, this does happen when the system gc occur, maybe we can use strong reference instead of weak reference.

[liutaohua]

Yes, this does happen when the system gc occur, maybe we can use strong reference instead of weak reference.

I need to continue to understand the business logic in order to understand the author's intentions.

We can wait for more comments on this question.

[lrhkobe]

The weak reference of ClientGroupWrapper in Session.java is designed to avoid circular reference. Because ClientGroupWrapper contains the reference of Session, and Session contains the reference of ClientGroupWrapper.

You are right. When system GC occurs, weak references will be recycled, but if the strong reference of ClientGroupWrapper also exists, maybe it will not be a problem.

We can find strong reference in the clientGroupMap field of ClientSessionGroupMapping.java :

private ConcurrentHashMap<String, ClientGroupWrapper> clientGroupMap;

[github-actions[bot]]

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

[zhengkezhou1]

@Pil0tXia, pls assigned this issue to me.

[Pil0tXia]

@zzzk1 OK

[pandaapo]

Community member explained why the design is like this and why there is no need to worry about the potential weak reference problem (https://github.com/apache/eventmesh/issues/446#issuecomment-882404842). Could anyone explain why this viewpoint is not recognized and this issue must be fixed?

社区成员解释了为什么这样设计以及为什么不需要担心弱引用的潜在问题（https://github.com/apache/eventmesh/issues/446#issuecomment-882404842 ），谁能解释一下该观点不被认可、必须修复该issue的原因？

[Pil0tXia]

Closed after https://github.com/apache/eventmesh/pull/4872#issuecomment-2155856899.