eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #3892] SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader have almost same body

Open pandaapo opened this issue 2 years ago • 6 comments

Fixes #3892.

Motivation

See "Enhancement Request" in issue.

Modifications

See "Describe the solution you'd like" in issue.

Documentation

  • Does this pull request introduce a new feature? no

pandaapo avatar May 10 '23 00:05 pandaapo

Codecov Report

Merging #3893 (e4b2db9) into master (0ce8d57) will increase coverage by 0.31%. The diff coverage is 78.16%.

:exclamation: Current head e4b2db9 differs from pull request most recent head d3129d8. Consider uploading reports for the commit d3129d8 to get more accurate results

@@             Coverage Diff              @@
##             master    #3893      +/-   ##
============================================
+ Coverage     14.24%   14.55%   +0.31%     
- Complexity     1320     1350      +30     
============================================
  Files           579      580       +1     
  Lines         28967    28811     -156     
  Branches       2802     2799       -3     
============================================
+ Hits           4125     4194      +69     
+ Misses        24450    24225     -225     
  Partials        392      392              
Impacted Files Coverage Δ
.../header/message/SendMessageBatchRequestHeader.java 0.00% <0.00%> (ø)
...eader/message/SendMessageBatchV2RequestHeader.java 0.00% <0.00%> (ø)
.../http/header/message/SendMessageRequestHeader.java 0.00% <0.00%> (ø)
.../http/header/message/BaseSendMsgRequestHeader.java 83.95% <83.95%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar May 16 '23 03:05 codecov[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Apr 22 '24 18:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 78.16092% with 19 lines in your changes missing coverage. Please review.

Project coverage is 14.55%. Comparing base (0ce8d57) to head (e4b2db9). Report is 533 commits behind head on master.

:exclamation: Current head e4b2db9 differs from pull request most recent head d3129d8

Please upload reports for the commit d3129d8 to get more accurate results.

Files Patch % Lines
.../http/header/message/BaseSendMsgRequestHeader.java 83.95% 13 Missing :warning:
.../header/message/SendMessageBatchRequestHeader.java 0.00% 2 Missing :warning:
...eader/message/SendMessageBatchV2RequestHeader.java 0.00% 2 Missing :warning:
.../http/header/message/SendMessageRequestHeader.java 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3893      +/-   ##
============================================
+ Coverage     14.24%   14.55%   +0.31%     
- Complexity     1320     1350      +30     
============================================
  Files           579      580       +1     
  Lines         28967    28811     -156     
  Branches       2802     2799       -3     
============================================
+ Hits           4125     4194      +69     
+ Misses        24450    24225     -225     
  Partials        392      392              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 22 '24 18:04 codecov-commenter

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Jun 22 '24 18:06 github-actions[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Aug 22 '24 18:08 github-actions[bot]