eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Enhancement] SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader have almost same body

Open pandaapo opened this issue 2 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Enhancement Request

  • SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader have almost same body.
  • Assert.assertThat() is deprecated in junit.
  • There is a more convenient method of initializing Map.

Describe the solution you'd like

  • Abstract SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader these three classes.
  • Use other api of junit.
  • Use ImmutableMap.of() to create and init Map.

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

pandaapo avatar May 09 '23 15:05 pandaapo

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

github-actions[bot] avatar Apr 22 '24 18:04 github-actions[bot]