eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #3880] Optimize ClientSessionGroupMapping

Open mxsm opened this issue 2 years ago • 6 comments

Fixes #3880

Motivation

Explain the content here. Explain why you want to make the changes and what problem you're trying to solve.

Modifications

  • Optimize ClientSessionGroupMapping
  • change ConcurrentHashMap<InetSocketAddress, Session> to ConcurrentHashMap<String, Session>

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

mxsm avatar May 07 '23 13:05 mxsm

Codecov Report

Merging #3881 (214e6e1) into master (e1e9aca) will increase coverage by 0.00%. The diff coverage is 1.96%.

:exclamation: Current head 214e6e1 differs from pull request most recent head 0364e2d. Consider uploading reports for the commit 0364e2d to get more accurate results

@@            Coverage Diff            @@
##             master    #3881   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28833   -14     
  Branches       2811     2809    -2     
=========================================
  Hits           4019     4019           
+ Misses        24455    24441   -14     
  Partials        373      373           
Impacted Files Coverage Δ
...e/admin/handler/RedirectClientByIpPortHandler.java 31.37% <0.00%> (ø)
...dmin/handler/RedirectClientBySubSystemHandler.java 9.09% <0.00%> (ø)
.../runtime/admin/handler/RejectAllClientHandler.java 12.50% <0.00%> (ø)
...ime/admin/handler/RejectClientByIpPortHandler.java 9.30% <0.00%> (ø)
.../admin/handler/RejectClientBySubSystemHandler.java 8.33% <0.00%> (ø)
...ntime/admin/handler/ShowClientBySystemHandler.java 15.38% <0.00%> (ø)
...tmesh/runtime/admin/handler/ShowClientHandler.java 14.81% <0.00%> (ø)
...ntmesh/runtime/admin/handler/TCPClientHandler.java 4.34% <0.00%> (+0.09%) :arrow_up:
.../runtime/admin/request/DeleteTCPClientRequest.java 0.00% <0.00%> (ø)
...ol/tcp/client/group/ClientSessionGroupMapping.java 0.81% <0.00%> (+0.03%) :arrow_up:
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar May 09 '23 07:05 codecov[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Apr 22 '24 18:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 1.96078% with 50 lines in your changes missing coverage. Please review.

Project coverage is 13.93%. Comparing base (e1e9aca) to head (214e6e1). Report is 604 commits behind head on master.

:exclamation: Current head 214e6e1 differs from pull request most recent head 0364e2d

Please upload reports for the commit 0364e2d to get more accurate results.

Files Patch % Lines
...ol/tcp/client/group/ClientSessionGroupMapping.java 0.00% 24 Missing :warning:
...ntime/core/protocol/tcp/client/task/HelloTask.java 0.00% 7 Missing :warning:
...ime/admin/handler/RejectClientByIpPortHandler.java 0.00% 5 Missing :warning:
...ntmesh/runtime/admin/handler/TCPClientHandler.java 0.00% 4 Missing :warning:
.../runtime/admin/handler/RejectAllClientHandler.java 0.00% 2 Missing :warning:
.../runtime/admin/request/DeleteTCPClientRequest.java 0.00% 2 Missing :warning:
...e/admin/handler/RedirectClientByIpPortHandler.java 0.00% 1 Missing :warning:
...dmin/handler/RedirectClientBySubSystemHandler.java 0.00% 1 Missing :warning:
.../admin/handler/RejectClientBySubSystemHandler.java 0.00% 1 Missing :warning:
...ntime/admin/handler/ShowClientBySystemHandler.java 0.00% 1 Missing :warning:
... and 2 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3881   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28833   -14     
  Branches       2811     2809    -2     
=========================================
  Hits           4019     4019           
+ Misses        24455    24441   -14     
  Partials        373      373           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 22 '24 18:04 codecov-commenter

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Jun 22 '24 18:06 github-actions[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Aug 22 '24 18:08 github-actions[bot]