eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #3877] Refactor EventMeshRecommendImpl

Open mxsm opened this issue 2 years ago • 3 comments

Fixes #3877

Motivation

Explain the content here. Explain why you want to make the changes and what problem you're trying to solve.

Modifications

  • Refactor EventMeshRecommendImpl

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

mxsm avatar May 07 '23 11:05 mxsm

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 13.93%. Comparing base (e1e9aca) to head (4c1d702). Report is 604 commits behind head on master.

:exclamation: Current head 4c1d702 differs from pull request most recent head 42ed2cd

Please upload reports for the commit 42ed2cd to get more accurate results.

Files Patch % Lines
...commend/DefaultEventMeshRecommendStrategyImpl.java 0.00% 10 Missing :warning:
...l/tcp/client/rebalance/EventmeshRebalanceImpl.java 0.00% 1 Missing :warning:
...e/core/protocol/tcp/client/task/RecommendTask.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3878   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28844    -3     
  Branches       2811     2811           
=========================================
  Hits           4019     4019           
+ Misses        24455    24452    -3     
  Partials        373      373           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '23 07:05 codecov[bot]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Jun 22 '24 18:06 github-actions[bot]