eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #3515] Do some code optimization[AuthTokenUtils]

Open kyooosukedn opened this issue 2 years ago • 12 comments

Fixes #3515 .

Motivation

Code Optimization on AuthTokenUtils.java Remove redundancy

Modifications

Remove duplicate code and redundancies

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

kyooosukedn avatar Apr 06 '23 22:04 kyooosukedn

image Please check the checkstyle.

Alonexc avatar Apr 07 '23 02:04 Alonexc

image Please check the checkstyle.

Hi, how do I get those warnings? I ran ./gradlew check and did code inspection on file AuthTokenUtils.java and found nothing, I have imported checkstyle.xml though

kyooosukedn avatar Apr 07 '23 13:04 kyooosukedn

@kyooosukedn Download this plugin: image

Import the checkstyle of the local project and check the box. image image image

Alonexc avatar Apr 12 '23 08:04 Alonexc

Hi @Alonexc Is there something else that needs to be done?

kyooosukedn avatar Apr 25 '23 21:04 kyooosukedn

Please resolve conflicts.

Pil0tXia avatar Jan 09 '24 14:01 Pil0tXia

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5850d54) 17.55% compared to head (12b521c) 17.59%. Report is 6 commits behind head on master.

:exclamation: Current head 12b521c differs from pull request most recent head 13b2bee. Consider uploading reports for the commit 13b2bee to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3644      +/-   ##
============================================
+ Coverage     17.55%   17.59%   +0.04%     
+ Complexity     1778     1774       -4     
============================================
  Files           797      797              
  Lines         29871    29786      -85     
  Branches       2581     2573       -8     
============================================
- Hits           5243     5242       -1     
+ Misses        24145    24063      -82     
+ Partials        483      481       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 14 '24 18:01 codecov[bot]

Hi @Pil0tXia, I have corrected as you suggested. Thank u for the review :)

kyooosukedn avatar Jan 16 '24 22:01 kyooosukedn

cc @Alonexc

Pil0tXia avatar Jan 19 '24 08:01 Pil0tXia

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

github-actions[bot] avatar Apr 22 '24 18:04 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (e04156b) to head (d48a930). Report is 69 commits behind head on master.

:exclamation: Current head d48a930 differs from pull request most recent head c1d287c

Please upload reports for the commit c1d287c to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #3644       +/-   ##
============================================
- Coverage     16.20%       0   -16.21%     
============================================
  Files           857       0      -857     
  Lines         30883       0    -30883     
  Branches       2685       0     -2685     
============================================
- Hits           5005       0     -5005     
+ Misses        25410       0    -25410     
+ Partials        468       0      -468     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 22 '24 18:04 codecov-commenter

@kyooosukedn Sorry for the delay. May you please resolve conflicts? 😊

@Alonexc May you please help merge this PR?

Pil0tXia avatar Apr 23 '24 03:04 Pil0tXia

@Alonexc @Pil0tXia kindly review this, thanks :)

kyooosukedn avatar Apr 28 '24 11:04 kyooosukedn

Closing to re-trigger CI.

Pil0tXia avatar Jun 01 '24 16:06 Pil0tXia