[ISSUE #3402]"getExtension()" can return null.[Trace]

[harshithasudhakar]

trafficstars

Fixes #3402

Motivation

Using requireNonNull() to check incoming references, can control the point in time when the exception will be thrown.

Modifications

Included "Object.requireNonNull()"

Documentation

• Does this pull request introduce a new feature? (yes / no) No
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) No

[harshithasudhakar]

Hi @harshithasudhakar CI not pass, Please check it

I have rectified the issue now.

[scwlkq]

@pandaapo 你好👋 我想找一些初级的issue但是看这个貌似已经解决了但是没有关闭，这里还有其他直接commit的点吗？

hello 👋 I am looking for some beginner issues, but it seems that they have been resolved but not closed. Are there any other direct commit points here?

[mxsm]

@pandaapo 你好👋 我想找一些初级的issue但是看这个貌似已经解决了但是没有关闭，这里还有其他直接commit的点吗？

hello 👋 I am looking for some beginner issues, but it seems that they have been resolved but not closed. Are there any other direct commit points here?

@scwlkq Hi you can try this issue #4502 ,If you are interested, I can assign this issue to you.

[codecov[bot]]

Codecov Report

Merging #3632 (97c99de) into master (d3f688d) will decrease coverage by 0.01%. The diff coverage is 0.00%.

:exclamation: Current head 97c99de differs from pull request most recent head ab4d13a. Consider uploading reports for the commit ab4d13a to get more accurate results

@@             Coverage Diff              @@
##             master    #3632      +/-   ##
============================================
- Coverage     15.47%   15.47%   -0.01%     
  Complexity     1452     1452              
============================================
  Files           691      691              
  Lines         28106    28112       +6     
  Branches       2626     2629       +3     
============================================
  Hits           4349     4349              
- Misses        23312    23318       +6     
  Partials        445      445              

Files	Coverage Δ
...java/org/apache/eventmesh/runtime/trace/Trace.java	0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[pandaapo]

https://github.com/apache/eventmesh/pull/3632#pullrequestreview-1434053124

https://github.com/apache/eventmesh/pull/3632#discussion_r1199499713

What is the significance of these modifications in this PR? @mxsm

[Pil0tXia]

What is the significance of these modifications in this PR? @mxsm

@pandaapo In your screenshots, it seems little changes have been made indeed.

[Pil0tXia]

Any progress can be made in this PR?

[github-actions[bot]]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 15.47%. Comparing base (d3f688d) to head (97c99de). Report is 236 commits behind head on master.

:exclamation: Current head 97c99de differs from pull request most recent head ab4d13a

Please upload reports for the commit ab4d13a to get more accurate results.

Files	Patch %	Lines
...java/org/apache/eventmesh/runtime/trace/Trace.java	0.00%	8 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3632      +/-   ##
============================================
- Coverage     15.47%   15.47%   -0.01%     
  Complexity     1452     1452              
============================================
  Files           691      691              
  Lines         28106    28112       +6     
  Branches       2626     2629       +3     
============================================
  Hits           4349     4349              
- Misses        23312    23318       +6     
  Partials        445      445              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.