eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #1307] Knative Connector: Support Cluster-Mode and Broadcast-Mode Listener.

Open pchengma opened this issue 3 years ago • 1 comments

Fixed #1307.

Motivation

Support cluster-mode and broadcast-mode listener in Knative-Connector. This PR will be merged into knative-connector branch first.

Modifications

Logic

Listener (cluster or broadcast mode) calls consume method after subscribe according to action type (CommitMessage, ReconsumeLater, or ManualACK).

Implementation

  • Added broadcast-mode message listener
  • Added consume statement calling in subscribe method

How to Test

Same as the integration test steps in demo (see document for details)

Documentation

  • Does this pull request introduce a new feature? Yes.
  • If yes, how is the feature documented? Not documented.
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation. The documentation issue will be created along with another PR specifically for documentation.

pchengma avatar Sep 20 '22 06:09 pchengma

Codecov Report

Merging #1342 (d6d35d8) into knative-connector (69d3d99) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@                  Coverage Diff                   @@
##             knative-connector   #1342      +/-   ##
======================================================
- Coverage                 9.88%   9.86%   -0.02%     
  Complexity                 629     629              
======================================================
  Files                      380     380              
  Lines                    23386   23419      +33     
  Branches                  2551    2555       +4     
======================================================
  Hits                      2311    2311              
- Misses                   20869   20902      +33     
  Partials                   206     206              
Impacted Files Coverage Δ
...sh/connector/knative/consumer/DefaultConsumer.java 0.00% <0.00%> (ø)
...h/connector/knative/consumer/PullConsumerImpl.java 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 20 '22 07:09 codecov[bot]