eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Bug] HTTP protocol when multiple consumers use the same ConsumerGroup, the EventMeshConsumer Topic status is inconsistent ?

Open ruanjf opened this issue 2 years ago • 4 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Environment

Mac

EventMesh version

master

What happened

refresh consumer group do not update EventMeshConsumer.consumerGroupConfig. Causes verification of topic to fail?

  1. subscription change for Subscribe,Unsubscribe https://github.com/apache/incubator-eventmesh/blob/f6aefd75e8ca80d58a6a6e5b188b2b78ba46c449/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer/ConsumerManager.java#L180-L210

  2. consumer group state change https://github.com/apache/incubator-eventmesh/blob/f6aefd75e8ca80d58a6a6e5b188b2b78ba46c449/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer/ConsumerManager.java#L322-L342

  3. refresh consumer group do not update EventMeshConsumer.consumerGroupConfig https://github.com/apache/incubator-eventmesh/blob/f6aefd75e8ca80d58a6a6e5b188b2b78ba46c449/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer/ConsumerGroupManager.java#L70-L83

  4. check topic when consume message (fail) https://github.com/apache/incubator-eventmesh/blob/f6aefd75e8ca80d58a6a6e5b188b2b78ba46c449/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer/EventMeshConsumer.java#L125-L138

How to reproduce

Start multiple consumers use the same ConsumerGroup

Debug logs

no topicConfig found, consumerGroup:test-group topic:test

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

ruanjf avatar Sep 14 '22 05:09 ruanjf

Welcome to the Apache EventMesh (incubating) community!! We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context. We will be here shortly.

If you are interested in contributing to our project, please let us know! You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Group: wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

github-actions[bot] avatar Sep 14 '22 05:09 github-actions[bot]

@ruanjf welcome to fix it~

qqeasonchen avatar Sep 21 '22 06:09 qqeasonchen

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

github-actions[bot] avatar Apr 22 '24 18:04 github-actions[bot]

@ruanjf May you please help submit a bugfix PR if this bug still exists? I would greatly appreciate it for that.

Pil0tXia avatar Apr 24 '24 12:04 Pil0tXia

@Pil0tXia Can't reproduce now

ruanjf avatar Jun 16 '24 07:06 ruanjf

Thanks for your verification! Then I will close this issue as completed. Please feel free to reopen it if you have something more to share with us.

Pil0tXia avatar Jun 16 '24 08:06 Pil0tXia