eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[ISSUE #1243] Upgrade pravega connector

Open LIU-WEI-git opened this issue 3 years ago • 3 comments

Fixes issue #1243. Related PR #1203.

Motivation

Upgrade pravega connector

Modifications

  • SubscribeTask supports EventMeshAsyncConsumeContext.commit
  • Consumer support broadcast and clustering message model
  • Upgrade the creation of ReaderGroup and Reader.
    • Use {consumerGroup}-{topic} for clustering model or UUID for broadcast model as ReaderGroup name
    • Set AUTOMATIC_RELEASE_AT_LAST_CHECKPOINT as the retention strategy of all ReaderGroup

LIU-WEI-git avatar Sep 08 '22 08:09 LIU-WEI-git

Codecov Report

Merging #1237 (6f60a8d) into master (49a32d7) will decrease coverage by 0.02%. The diff coverage is 0.00%.

:exclamation: Current head 6f60a8d differs from pull request most recent head cb09085. Consider uploading reports for the commit cb09085 to get more accurate results

@@             Coverage Diff              @@
##             master    #1237      +/-   ##
============================================
- Coverage     10.47%   10.45%   -0.03%     
+ Complexity      768      764       -4     
============================================
  Files           435      432       -3     
  Lines         26554    26550       -4     
  Branches       2924     2928       +4     
============================================
- Hits           2782     2776       -6     
- Misses        23511    23513       +2     
  Partials        261      261              
Impacted Files Coverage Δ
...entmesh/connector/pravega/PravegaConsumerImpl.java 0.00% <0.00%> (ø)
...entmesh/connector/pravega/PravegaProducerImpl.java 0.00% <0.00%> (ø)
...ntmesh/connector/pravega/client/PravegaClient.java 0.00% <0.00%> (ø)
...entmesh/connector/pravega/client/PravegaEvent.java 0.00% <ø> (ø)
...ntmesh/connector/pravega/client/SubscribeTask.java 0.00% <0.00%> (ø)
...tandalone/broker/task/HistoryMessageClearTask.java 29.41% <0.00%> (-17.65%) :arrow_down:
...mesh/connector/standalone/broker/MessageQueue.java 32.46% <0.00%> (-7.80%) :arrow_down:
.../admin/handler/QueryRecommendEventMeshHandler.java 90.32% <0.00%> (-2.28%) :arrow_down:
... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 08 '22 10:09 codecov[bot]

@LIU-WEI-git please split into several smaller pr.

qqeasonchen avatar Sep 08 '22 14:09 qqeasonchen

@LIU-WEI-git please split into several smaller pr.

Hi, I have split this PR and started PR #1240 and PR #1242. Please review them.

LIU-WEI-git avatar Sep 08 '22 14:09 LIU-WEI-git