eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Enhancement] New dependencies were introduced without updating the licenses

Open hezean opened this issue 2 years ago • 2 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Enhancement Request

https://github.com/apache/incubator-eventmesh/commit/47db0db4fe5c87c627f1162e3f16c5cd298c165f introduced some new dependencies, the known-dependencies.txt has been updated in https://github.com/apache/incubator-eventmesh/commit/952ffd9e0393b02e5c6eeddbbbaab82f6f706b3c, but copies of 3rd-party licenses were not updated

Describe the solution you'd like

Update licenses in the folder, you need to be care about the addition lines in https://github.com/apache/incubator-eventmesh/commit/952ffd9e0393b02e5c6eeddbbbaab82f6f706b3c

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

hezean avatar Aug 26 '22 14:08 hezean

I can't figure out why this pr associate with this issue, is this correct ? @HeZean

xwm1992 avatar Aug 30 '22 01:08 xwm1992

I can't figure out why this pr associate with this issue, is this correct ? @HeZean

They are not associated, when I committed to that PR, I found the license checker CI failed in https://github.com/apache/incubator-eventmesh/pull/1105#issuecomment-1228594562 and thus opened this issue.

hezean avatar Aug 30 '22 04:08 hezean

Closing this stale issue since the license was fixed in some commit.

hezean avatar Nov 06 '22 16:11 hezean