eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Feature] Support Skywalking tracing plugin

Open qqeasonchen opened this issue 3 years ago • 10 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Feature Request

Now eventmesh default support zipkin as tracing system, Skywalking is a widely used APM system and we can add a plugin adapter for eventmesh.

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

qqeasonchen avatar Aug 26 '22 11:08 qqeasonchen

hi @qqeasonchen do you have any ideas ? if I plan to enhance three clients (TCP. HTTP, GRPC) and event mesh server, it's suitable ?

heihei180 avatar Oct 29 '22 06:10 heihei180

@heihei180 you mean implement Skywalking tracing for TCP/HTTP/GRPC?

qqeasonchen avatar Oct 30 '22 16:10 qqeasonchen

@heihei180 you mean implement SkyWalking tracing for TCP/HTTP/GRPC?

yes, i mean enhance eventMesh's three clients (where handle network io); in this way, user can view the activity of eventMesh from skyWalking UI. do you have any suggestions?

heihei180 avatar Oct 31 '22 07:10 heihei180

@heihei180 sure, you can implement a trace plugin by skywalking.

qqeasonchen avatar Oct 31 '22 07:10 qqeasonchen

@qqeasonchen implement in this project ? rather than as a plugin in skywalking-java?

heihei180 avatar Oct 31 '22 07:10 heihei180

@heihei180 just like this https://github.com/apache/incubator-eventmesh/tree/master/eventmesh-trace-plugin/eventmesh-trace-pinpoint

qqeasonchen avatar Oct 31 '22 07:10 qqeasonchen

I understand your meaning. call the API of skywalking directly to monitor the status of the eventmesh server. However, another problem is that the client behavior of eventmesh cannot be monitored. but I will do this and give me some time.

heihei180 avatar Oct 31 '22 09:10 heihei180

@qqeasonchen It seems that this feature has not been updated recently, can you assign it to me? I will try to open some issues to split into smaller tasks.

seriouszyx avatar Dec 12 '22 07:12 seriouszyx

I get that EventMesh uses OpenTelemetry to collect trace data from the server, and the tracing plugin exports the trace data to other systems (such as Zipkin and Pinpoint). However, It is hard to implement the Skywalking plugin with such ideas as there is tech block (ref).

Instead, we can support jaeger tracing plugin which can handle trace data exported by OpenTelemetry. And we can also support Skywalking metrics plugin to export EventMesh metrics data to Skywalking.

What's your opinion, @qqeasonchen ?

seriouszyx avatar Dec 16 '22 09:12 seriouszyx

@seriouszyx we can have a discuss meeting.

qqeasonchen avatar Dec 20 '22 06:12 qqeasonchen