eventmesh
eventmesh copied to clipboard
[ISSUE #1139] add plugin module
Fixes #1139 .
Motivation
add plugin module
Modifications
- the plugin module has been added to the eventmesh-go project, and log/naming/database has been implemented.
- replacing the existing log module, adding a rolllwrite component based on zap, providing better write performance, and asynchronously discarding logs when the disk is full, so that the service will not be blocked.
- add server/main file to facilitate verification of new functions.
Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
Codecov Report
Merging #1140 (f11a422) into eventmesh-server-go (56152da) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## eventmesh-server-go #1140 +/- ##
=====================================================
Coverage 9.95% 9.95%
Complexity 640 640
=====================================================
Files 382 382
Lines 23640 23640
Branches 2619 2619
=====================================================
Hits 2353 2353
Misses 21067 21067
Partials 220 220
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
- Move the code in internal into pkg package, as eventmesh is an opensource project, code in the pkg package maybe better instead in the internal
- Move the main.go into cmd/workflow/main.go as workflow is a single process, we will start another process in the cmd/runtime
- I see you are using yaml configuration, then delete toml in the configs directory
- Move the event-mesh-server.yaml into configs directory
- Move the code in internal into pkg package, as eventmesh is an opensource project, code in the pkg package maybe better instead in the internal
- Move the main.go into cmd/workflow/main.go as workflow is a single process, we will start another process in the cmd/runtime
- I see you are using yaml configuration, then delete toml in the configs directory
- Move the event-mesh-server.yaml into configs directory
- agree
- It is not recommended to move the server.go and main.go files to the cmd directory. cmd is generally used to start programs based on the command line, and different configuration parameters can be passed in based on this. The server.go and main.go files here are the entry points for the eventmesh-server service. Personally, it is recommended to put them in the root directory or create a new server directory. Subsequent workflow/catalog will have a separate directory.
- 3/4 The current function of config package is to parse the configuration file when the service is running. If the configuration file is placed in this package, the responsibility of the package will be different (you can create a conf directory and put the configuration file in this directory when the service is running). ), the practice of etcd is also referred to here (the configuration file is placed directly in the root directory of the source code)